Skip to content
This repository has been archived by the owner on Jun 10, 2018. It is now read-only.

Add bundle command mapping check to make it compatible with rvm1-capistrano3 and other gems that use sshkit command mapping #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

redvulps
Copy link

No description provided.

@ydkn
Copy link
Owner

ydkn commented Jun 13, 2015

Thanks for the PR.

Two remarks/question:
Any particular reason why you aren't using SSHKit.config.command_map[:bundle] directly instead of accessing only the prefix SSHKit.config.command_map.prefix[:bundle] and then adding the bundle command itself again (+ ' bundle')?
If prefix[:bundle] isn't a array or it has multiple prefixes using bundle_mapped.first will fail or won't include the the entire command - at least I think that would happen.

@redvulps
Copy link
Author

Hmmm, that's a behavior of capistano3-rvm1, I'll check rbenv to see if it behaves different and update the code. Thanks for the advice!

@ydkn
Copy link
Owner

ydkn commented Jul 28, 2015

I made the changes I was talking about in branch command_map. It would be great if you could try if this still works in your env.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants