Stream assistant events as threadStatus #1949
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyphilemon
force-pushed
the
jrmy/ai-1067-feat-support-all-stream-events-in-useassistant
branch
from
cd44fdf to
2498503
Compare
jeremyphilemon
force-pushed
the
jrmy/ai-1067-feat-support-all-stream-events-in-useassistant
branch
from
24fa9c2 to
7358c7b
Compare
jeremyphilemon
changed the title
lgrammel
reviewed
Jun 14, 2024
| break; | ||
| } | ||
|
|
||
| case 'assistant_control_data': { | ||
| setThreadId(value.threadId); |
There was a problem hiding this comment.
how are we setting the thread id now?
There was a problem hiding this comment.
It's set here when the event type is thread.run.created
| content: '', | ||
| data: value.data, |
There was a problem hiding this comment.
do we still have the ability to send data? i think it was for custom data
| }), | ||
| ); | ||
| }); | ||
|
|
||
| describe('loading state', () => { | ||
| it('should show loading state', async () => { |
There was a problem hiding this comment.
leave old test to ensure backwards compat?
jeremyphilemon
force-pushed
the
jrmy/ai-1067-feat-support-all-stream-events-in-useassistant
branch
from
57f286b to
37bcd36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b:<AssistantStreamEvent>threadStatus