Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request to switch anthy-unicode #166

Open
fujiwarat opened this issue Nov 13, 2020 · 7 comments
Open

Request to switch anthy-unicode #166

fujiwarat opened this issue Nov 13, 2020 · 7 comments

Comments

@fujiwarat
Copy link

I request to have an option to build uim-anthy with anthy-unicode because anthy has not been updated officially.
I develop and maintain anthy-unicode which is forked from anthy and ibus-anthy has already used anthy-unicode.
I agreed with the original anthy maintainer to develop anthy-unicode.

anthy-unicode changes:

  • internal data EUC-JP to UTF-8
  • private dic in $HOME/.anthy to $XDG_CONFIG_HOME/anthy
@kou
Copy link
Member

kou commented Nov 13, 2020

OK.
Let's working on this!

@fujiwarat
Copy link
Author

Thank you!

@takehora
Copy link

takehora commented Feb 25, 2023 •
edited
Loading

After using autogen.sh to create configure and run it with --enable-anthy-utf8, configure can't find anthy-utf8 because the checking function use "anthy >= 8622", but the current anthy-utf8 version is "Version: 1.0.0.20211224".
Could you fix the script?

/usr/lib64/pkgconfig/anthy-unicode.pc on Slackware64-Current

#To Be Done
# See http://www.freedesktop.org/Software/pkgconfig
prefix=/usr
exec_prefix=/usr
includedir=${prefix}/include/anthy-unicode-1.0
libdir=/usr/lib64

Name: anthy
Description: Japanese conversion engine
Version: 1.0.0.20211224
Cflags: -I${includedir}
Libs: -L${libdir} -lanthy-unicode -lanthydic-unicode

@kou
Copy link
Member

kou commented Feb 26, 2023

We need to use anthy-unicode not anthy to use anthy-unicode. For example:

diff --git a/configure.ac b/configure.ac
index 56fb1dd4..14d923b4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -141,11 +141,16 @@ AC_ARG_WITH(anthy-utf8,
   [with_anthy_utf8=no])
 
 if test "x$with_anthy_utf8" != xno; then
-  PKG_CHECK_MODULES(ANTHY_UTF8, anthy >= 8622,
+  PKG_CHECK_MODULES(ANTHY_UTF8,
+                    anthy-unicode,
                     [with_anthy_utf8=yes
                      AC_DEFINE(LIBANTHY_UTF8_CAPABLE, 1,
                      [libanthy can handle UTF-8])],
-                     with_anthy_utf8=no)
+                    [PKG_CHECK_MODULES(ANTHY_UTF8, anthy >= 8622,
+                                       [with_anthy_utf8=yes
+                                        AC_DEFINE(LIBANTHY_UTF8_CAPABLE, 1,
+                                        [libanthy can handle UTF-8])],
+                                       with_anthy_utf8=no)])
 fi
 
 AM_CONDITIONAL(ANTHY_UTF8, test "x$with_anthy_utf8" = xyes)

@fujiwarat
Copy link
Author

LGTM.

@kou
Copy link
Member

kou commented Feb 27, 2023

Could you open a pull request?

fujiwarat added a commit to fujiwarat/uim that referenced this issue Mar 3, 2023
@fujiwarat
configure: Fix --with-anthy-utf8 option (uim#166)
0ecdb1c
fujiwarat added a commit to fujiwarat/uim that referenced this issue Mar 3, 2023
@fujiwarat
configure: Support anthy-unicode (uim#166)
aac19d0
@fujiwarat
Copy link
Author

I filed #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kou @fujiwarat @takehora