BaseTools: Add ImageCapsuleSupport field to header #6473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER structure has an additional field 'ImageCapsuleSupport' which is ommitted when generating capsules via GenFds. Add basic support for it by hardcoding it to 1, indicating that the capsule supports authentication. Signed-off-by: Rebecca Cran <[email protected]>
tianocore-assign-reviewers
bot
requested review from
BobCF,
lgao4 and
YuweiChen1110
|
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
This pull request has been automatically been closed because it did not have any activity in 60 days and no follow up within 7 days after being marked stale. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed when adding support for authenticated capsule updates that the code in GenFds was missing the last field from EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER. I don't know if it makes any difference, but we should probably be including it.
Note Obviously this is a very basic implementation which isn't complete and probably shouldn't be merged.
How This Was Tested
Generated capsules and verified they installed correctly via FMP.
Integration Instructions
N/A