Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharp below v0.33 requires a build environment #22235

Open
LunaticMuch opened this issue Nov 21, 2024 · 2 comments
Open

Sharp below v0.33 requires a build environment #22235

LunaticMuch opened this issue Nov 21, 2024 · 2 comments
Labels
good first issue Good for newcomers issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: core:upload Source is core/upload package source: dependencies Source is dependency problem status: confirmed Confirmed by a Strapi Team member or multiple community members version: 5

Comments

@LunaticMuch
Copy link

LunaticMuch commented Nov 21, 2024 •
edited
Loading

Bug report

Required System information

  • Node.js version: v20.16.0
  • NPM version: 10.9.0
  • Strapi version: 5.4.0
  • Database: SQLIte
  • Operating system: MacOS Sequoia
  • Is your project Javascript or Typescript: Typescript

Describe the bug

In the current strapi version, the package @strapi/upload uses sharp. Sharp requires some additional binaries which are either built locally or pulled from github.
This causes troubles when strapi is being install in a corporate environment where a private registry and there's no direct access to internet and/or the proxy blocks the download of binaries.

Steps to reproduce the behavior

In a corporate environment just make a yarn install

Expected behavior

The install should work smoothly without requiring extra pull of binaries from github.
This is fixed using sharp v0.33.5

Additional context

There's a thread on sharp
@LunaticMuch LunaticMuch changed the title Sharp below v0.33 requires a build environmet Sharp below v0.33 requires a build environment Nov 21, 2024
@LunaticMuch LunaticMuch mentioned this issue Nov 21, 2024
Open
@derrickmehaffy derrickmehaffy added issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around status: confirmed Confirmed by a Strapi Team member or multiple community members source: core:upload Source is core/upload package source: dependencies Source is dependency problem version: 5 labels Nov 21, 2024
@github-project-automation github-project-automation bot moved this to To be reviewed (Open) in Developer Experience Squad Nov 21, 2024
@github-project-automation github-project-automation bot moved this to To be reviewed in Content Squad v4 Nov 21, 2024
@derrickmehaffy
Copy link
Member

Hey @LunaticMuch would you be willing to open a PR on this one?

@derrickmehaffy derrickmehaffy added the good first issue Good for newcomers label Nov 21, 2024
@LunaticMuch
Copy link
Author

Hey @LunaticMuch would you be willing to open a PR on this one?

Done already 😄 #22237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: core:upload Source is core/upload package source: dependencies Source is dependency problem status: confirmed Confirmed by a Strapi Team member or multiple community members version: 5
Projects
Content Squad v4
Status: To be reviewed
Developer Experience Squad
Status: To be reviewed (Open)
Strapi 5 - Bug Tracker
Status: To triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LunaticMuch @derrickmehaffy