Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hostname is automatically converted to uppercase (v1.21.1) #6411

Open
ahaoboy opened this issue Nov 24, 2024 · 2 comments · May be fixed by #6343
Open

hostname is automatically converted to uppercase (v1.21.1) #6411

ahaoboy opened this issue Nov 24, 2024 · 2 comments · May be fixed by #6343
Labels
🐛 bug Something isn't working as expected.

Comments

@ahaoboy
Copy link

ahaoboy commented Nov 24, 2024 •
edited
Loading

Current Behavior

hostname is automatically converted to uppercase

v1.21.1
image

Expected Behavior

v1.20.1
image

image

Possible Solution

Is it possible to configure the string to use uppercase or lowercase?

Environment

  • Starship version: 1.21.1
  • fish version: fish, version 3.7.1
  • Operating system: Windows 10.0.26100
  • Terminal emulator:
  • Git Commit Hash: 47ccc36
  • Branch/Tag: master
  • Rust Version: rustc 1.82.0 (f6e511eec 2024-10-15)
  • Rust channel: stable-x86_64-pc-windows-msvc release
  • Build Time: 2024-10-18 16:32:39 +00:00

Relevant Shell Configuration

if status is-interactive
    # Commands to run in interactive sessions can go here
end
fish_add_path $HOME/.cargo/bin
fish_add_path $HOME/.deno/bin

set -U fish_greeting

# set -x CARGO_TARGET_DIR "$HOME/ct"
set -x DENO_INSTALL "$HOME/.deno"

set -x SHELL /usr/bin/fish
 
alias ll="ls -lh"
 
starship init fish | source

Starship Configuration

format = """
[ ](#DA627D bg:#DA627D)\
$hostname\
[](bg:#DA627D fg:#DA627D)\
$directory\
[](fg:#DA627D bg:#FCA17D)\
$git_branch\
$git_status\
[](fg:#FCA17D bg:#86BBD8)\
[](fg:#86BBD8 bg:#06969A)\
[](fg:#06969A bg:#33658A)
$character
"""
command_timeout= 20000

[hostname]
ssh_only = false
format = '[$hostname](bg:#DA627D fg:black)'
disabled = false
ssh_symbol = ""

[character]
success_symbol = ""
error_symbol = ""
vimcmd_symbol = ""

[directory]
style = "bg:#DA627D  fg:black"
format = "[$path ]($style)"
truncation_length = 3
truncation_symbol = "…/"

[directory.substitutions]
"Documents" = "󰈙 "
"Downloads" = ""
"Music" = ""
"Pictures" = ""

[git_branch]
symbol = ""
style = "bg:#FCA17D fg:black"
format = '[ $symbol $branch ]($style)'

[git_status]
style = "bg:#FCA17D fg:black"
format = '[$all_status$ahead_behind ]($style)'
@ahaoboy ahaoboy added the 🐛 bug Something isn't working as expected. label Nov 24, 2024
@ahaoboy
Copy link
Author

ahaoboy commented Nov 24, 2024

ardaku/whoami#121

@davidkna davidkna linked a pull request Nov 24, 2024 that will close this issue
Open
5 tasks
@davidkna
Copy link
Member

#6343 includes a fix for this issue by using a different function in whoamion Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working as expected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(hostname): use DNS instead of NetBIOS name on Windows davidkna/starship
2 participants
@davidkna @ahaoboy