Skip to content

get_images sometimes fails with danbooru #6

Open
@f8upd8

Description

Describe the bug
Fails to fetch images with get_images from danbooru in case the result contains a taken down image (flagges by is_banned). It throws "ValueError: Failed to get data"

To Reproduce
Ask for enough images with get_images from danbooru

Expected behavior
Just skip over the post and return the images

Desktop (please complete the following information):

  • OS: Debian Bullseye
  • Python 3.10

Additional context
I fixed the bug by modifying the parser code and will propose a pull request referencing the issue. Also, I'd suggest removing try except block from danbooru where it says "ValueError(f"Failed to get data") as it is not descriptive and I had to remove it to track down the issue myself. I will do it in the pull request.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions