Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work as expected in combination with Fluent #114

Open
AljosaB opened this issue Aug 7, 2024 · 3 comments
Open

Doesn't work as expected in combination with Fluent #114

AljosaB opened this issue Aug 7, 2024 · 3 comments
Labels

Comments

@AljosaB
Copy link

AljosaB commented Aug 7, 2024

Expected result

  • Each localisation can have it's own publishing time set

Behaviour + steps

  1. Create a page in locale1 and set publish date in future // there is a new record in QueuedJobDescriptor with locale1 written in SavedJobData
  2. Localise page in locale2; you can see warning of emabrgo and same date as in locale1 although we didn't set the emabargo for locale2 yet
  3. Set emabargo date for locale2 // the previous QueuedJobDescriptor record gets deleted and new one with locale2 written in SavedJobData
  4. Extra step: switch back to locale1 and set the emargo date again // this time new QueuedJobDescriptor get's created with locale1 written in SaveJobData

Problem

  • After creating localisation in locale2, the warning shouldn't be displayed as we didn't set any embargo for that locale yet
  • After step 3 we have only one QueuedJobDescriptor for locale2 instead 2 for both locales
@chrispenny
Copy link
Member

Thanks for raising this with such detailed steps to reproduce!

The bugs you've raised under With EmbargoExpiryFluentExtension definitely warrant looking in to and resolving. We need to make sure that the messaging is clear (for each locale respectively) and that the correct jobs are created and maintained.

I don't think we would spend any time on Without EmbargoExpiryFluentExtension, as the expectation would be that you do use the EmbargoExpiryFluentExtension if you have Fluent installed. I'm going to keep a record of them here, but I'm going to remove them from the Issue description so that the focus is on With EmbargoExpiryFluentExtension.


Originally in the Issue description:

Without EmbargoExpiryFluentExtension (https://github.com/silverstripe-terraformers/silverstripe-embargo-expiry/blob/master/docs/en/fluent-support.md)

How to reproduce

  • create a page in locale1 and set publish date in future
  • localise page in locale2; you can see warning of emabrgo and same date as in locale1
  • run dev/tasks/ProcessJobQueueTask (after the set time)

Expected result

  • page published in all locales

Actual result

  • page in locale1 still in draft
  • page in locale2 published

DB result

  • SiteTree_Live record created
  • SiteTree_Localised_Live record created for locale2, no new record for locale1

@chrispenny chrispenny added the bug label Aug 7, 2024
@chrispenny
Copy link
Member

@AljosaB could you please also let us know what version of Embargo & Expiry this was experienced on?

@AljosaB
Copy link
Author

AljosaB commented Sep 18, 2024

@chrispenny I somehow missed your response. As instructed I always test things on latest clean SS installation (in this case SS 5.2.x) and only thing added extra was embargo-expiry v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants