Upload source dist. Cmake to 3.10

sarvex · Apr 24, 2020 · e40b821 · e40b821
1 parent 3902a69
commit e40b821
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -43,6 +43,7 @@ jobs:
         cd build
         cmake ../
         cmake --build . -- -j 6
+        echo "Running ./src/runtest"
         ./src/runtest
         valgrind --leak-check=full --show-leak-kinds=all --errors-for-leak-kinds=all  ./src/runtest
 
@@ -79,11 +80,11 @@ jobs:
         TWINE_USERNAME: __token__
         TWINE_NON_INTERACTIVE: 1
         TWINE_PASSWORD: ${{ secrets.test_pypi_password }}
-      run: twine upload --non-interactive --skip-existing --verbose 'dist/*whl'
+      run: twine upload --non-interactive --skip-existing --verbose 'dist/*'
     - name: Publish distribution to PyPI
       if: startsWith(github.event.ref, 'refs/tags')
       env:
         TWINE_USERNAME: __token__
         TWINE_NON_INTERACTIVE: 1
         TWINE_PASSWORD: ${{ secrets.pypi_password }}
-      run: twine upload --non-interactive --skip-existing --verbose 'dist/*whl'
+      run: twine upload --non-interactive --skip-existing --verbose 'dist/*'
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,5 +1,5 @@
-# add_compile_definitions() was introduced in cmake 3.12
-CMAKE_MINIMUM_REQUIRED(VERSION 3.1.0 FATAL_ERROR)
+# add_compile_definitions() was introduced in cmake 3.12 but this compiles on 3.10
+CMAKE_MINIMUM_REQUIRED(VERSION 3.10.0 FATAL_ERROR)
 set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_POSITION_INDEPENDENT_CODE ON)