Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Density sampling and EM projections not working as expected #915

Open
ichem001 opened this issue Nov 5, 2015 · 3 comments
Open

Density sampling and EM projections not working as expected #915

ichem001 opened this issue Nov 5, 2015 · 3 comments

Comments

@ichem001
Copy link
Contributor

ichem001 commented Nov 5, 2015

The current version of the EM and EM2D modules uses the KernelParameters.h file to sample the density at a given resolution and angstrom per pixel (apix).
However both uses the RadiusDependentKernelParameters (RDKP) to define the volume and sigma at which the density will be sampled.

At low resolution, the models looked okay given the resolution. However, upon using high resolution data, the simulated maps (respectively the projection) are not correct. This is easily shown by using standard EM software such as EMAN2.

Disabling the RadiusDependentKernelParameters seems to solve one of the issue at high resolution (proper density location but wrong voxel value even when using NumberOfElectron rather than mass when calculating the KP) but low resolution is still not working as expected.
Ubiquitin looks like a ball at 15A losing all the features (EMAN2 actually give proper features even at 15A resolution).

Obviously, disabling the RDKP is not ideal. I am not sure why it was implemented but I am sure there is a good reason for it to be there.

TL/TR: Incorrect density sampling (resolution and voxel intensity) from PDB when using RDKP.

@cgreenberg
Copy link
Contributor

Even though this issue is mostly solved with recent changes in IMP::em, I'm still finding errors in simulated maps. They still have a slight offset from the structure they're simulated from.

@ichem001
Copy link
Contributor Author

ichem001 commented Feb 3, 2016

What do you mean by offset? Resolution-wise or coordinate-wise?

@benmwebb
Copy link
Member

benmwebb commented Feb 3, 2016

If you mean coordinate-wise, it would be simple to write a (failing) test that simulated a map from a single atom, then compared the map centroid to the atom coordinates, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants