Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space in filename of Australian ACT statewide addresses #7569

Open
orangejulius opened this issue Nov 21, 2024 · 1 comment
Open

Space in filename of Australian ACT statewide addresses #7569

orangejulius opened this issue Nov 21, 2024 · 1 comment

Comments

@orangejulius
Copy link
Contributor

While doing some processing lately I noticed that there is exactly one address file in all of OA with a space in the filename:

julian@Julians-MacBook-Air ~/data/openaddresses $ find . -name '* *'
./au/act/statewide-addresses-ACTGOV Addresses.geojson

It's easy to handle spaces in automated scripts, but it's also easy to forget.

I think this space comes from this line. Can I safely remove the space in a PR to save other people some trouble?
@iandees
Copy link
Member

iandees commented Nov 21, 2024

Yup, lets change that line. We should probably modify the schema to prevent whitespace in that field too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orangejulius @iandees