Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix dead links #4814

Merged
merged 18 commits into from
Dec 5, 2024
Merged

[FIX] Fix dead links #4814

merged 18 commits into from
Dec 5, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Nov 28, 2024

  • Closes none

Changes proposed in this pull request:

  • fix dead links
  • add workflow to check links on doc build (via tox)
  • add config to ignore some dead links or redirect
  • update maintenance script
    • to not create sphinx reference for contributors without an active website
    • to create dummy masker / glm report on partial build (should speed up the build too)

Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.69%. Comparing base (c95ca03) to head (1ce85d8).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4814      +/-   ##
==========================================
+ Coverage   93.66%   93.69%   +0.03%     
==========================================
  Files         136      136              
  Lines       17143    17118      -25     
  Branches     2959     2947      -12     
==========================================
- Hits        16057    16039      -18     
+ Misses        576      571       -5     
+ Partials      510      508       -2     
Flag Coverage Δ
macos-latest_3.10_test_plotting 93.21% <ø> (+0.03%) ⬆️
macos-latest_3.11_test_plotting 93.21% <ø> (+0.03%) ⬆️
macos-latest_3.12_test_plotting 93.21% <ø> (+0.03%) ⬆️
macos-latest_3.13_test_plotting 93.21% <ø> (+0.03%) ⬆️
macos-latest_3.9_test_plotting 93.19% <ø> (+0.03%) ⬆️
ubuntu-latest_3.10_test_plotting 93.21% <ø> (+0.03%) ⬆️
ubuntu-latest_3.11_test_plotting 93.21% <ø> (+0.03%) ⬆️
ubuntu-latest_3.12_test_plotting 93.21% <ø> (+0.03%) ⬆️
ubuntu-latest_3.13_test_plotting 93.21% <ø> (+0.03%) ⬆️
ubuntu-latest_3.13_test_pre 93.23% <ø> (+0.03%) ⬆️
ubuntu-latest_3.9_test_min 69.43% <ø> (+0.08%) ⬆️
ubuntu-latest_3.9_test_plot_min 92.09% <ø> (+0.02%) ⬆️
ubuntu-latest_3.9_test_plotting 93.19% <ø> (+0.03%) ⬆️
windows-latest_3.10_test_plotting 93.19% <ø> (+0.03%) ⬆️
windows-latest_3.11_test_plotting 93.19% <ø> (+0.03%) ⬆️
windows-latest_3.12_test_plotting 93.19% <ø> (+0.03%) ⬆️
windows-latest_3.13_test_plotting 93.19% <ø> (+0.03%) ⬆️
windows-latest_3.9_test_plotting 93.17% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doc/glm/glm_intro.rst Outdated Show resolved Hide resolved
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@Remi-Gau Remi-Gau changed the title fix links [FIX] fix dead links Dec 3, 2024
@Remi-Gau Remi-Gau changed the title [FIX] fix dead links [FIX] Fix dead links Dec 3, 2024
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Dec 3, 2024

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@Remi-Gau Remi-Gau marked this pull request as ready for review December 5, 2024 00:27
@Remi-Gau Remi-Gau requested a review from man-shu December 5, 2024 08:56
Copy link
Contributor

@man-shu man-shu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Remi-Gau Remi-Gau merged commit 32f1097 into nilearn:main Dec 5, 2024
35 checks passed
@Remi-Gau Remi-Gau deleted the fix/links branch December 5, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants