Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-Crash #308

Open
H0Imes opened this issue Nov 15, 2024 · 3 comments
Open

Server-Crash #308

H0Imes opened this issue Nov 15, 2024 · 3 comments

Comments

@H0Imes
Copy link
Contributor

H0Imes commented Nov 15, 2024

There is an issue in the RayTraceUtil#rayTraceBlocks method that can cause an infinite loop, potentially resulting in a server crash.

Crash-Report: https://mclo.gs/fWDOgzF

@H0Imes
Copy link
Contributor Author

H0Imes commented Nov 15, 2024

The issue could be resolved by adding an iterationLimit and exiting the loop once the limit is reached

@0xE69
Copy link
Collaborator

0xE69 commented Nov 16, 2024

I will look further into this.

@0xE69
Copy link
Collaborator

0xE69 commented Nov 16, 2024

Confirmed, Looks like issues with methods;

at com.craftingdead.core.util.RayTraceUtil.rayTraceBlocks(RayTraceUtil.java:125)
at com.craftingdead.core.util.RayTraceUtil.rayTrace(RayTraceUtil.java:72)

Will have to check for misconfigured block shapes and also large scans for collisions, @nuklear71 We need to review block shapes to ensure there is nothing out of sorts.

@H0Imes

Are you able to check crash if you change max-tick-time=120000

I will try to get yourkit setup over the weekend and see if we can lock down the cause further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants