Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

disable loading from subdirectories #101

Open
art0007i opened this issue Jun 2, 2023 · 4 comments
Open

disable loading from subdirectories #101

art0007i opened this issue Jun 2, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@art0007i
Copy link
Member

art0007i commented Jun 2, 2023

I find this feature annoying more often than I find it useful. For example if I want to test something with only a single mod and temporarily disable every other mod I would just take all the current mods and throw them into a different folder. The easiest option would be just a subdirectory within mods called like "disabled" and then take them back out of there later.

I don't know if anyone at all uses the subdirectories feature at all. I assume it's there to allow better organization but it actually prevents me from organizing mods how I want (right now I need to put a disabled mods directory OUTSIDE the mods folder which gets kind of annoying to navigate).

A good middle ground would be to have some way to specify a folder shouldn't be searched by the mod loader so for example a dot. That way I could make a folder called ".disabled" and anything inside of there would be ignored, but also I think completely removing this feature is a good option, unless there are actually people who use that to organize their mods.

@XDelta
Copy link
Member

XDelta commented Jun 2, 2023

I personally don't use this either and found it some amount annoying as I'd sometimes do the same. The main benefit I suppose would be for mods that are packaged as zips or otherwise have multiple files associated with them can be grouped together in a folder.

@EIA485
Copy link
Member

EIA485 commented Jun 2, 2023

maybe we could add an option to nml's config to disable it. if we want to be generic then we could maybe make this a regex string for what sub directories to ignore

@zkxs
Copy link
Collaborator

zkxs commented Jun 3, 2023

For reference, the PR that added recursive mod loading: #51

I think adding a NML config option to opt out of this behavior would be fine.

@zkxs zkxs added the enhancement New feature or request label Jun 4, 2023
@art0007i
Copy link
Member Author

art0007i commented Jun 4, 2023

I'd say ignoring folders with a dot at the beginning is the best option. tying this behavior to config would mean that any mod managers/updaters have to respect that option and it could get messy.

Or just revert the PR :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants