Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📁 TDrive - Improve access management popup #2773

Open
RomaricMourgues opened this issue Mar 9, 2023 · 6 comments
Open

📁 TDrive - Improve access management popup #2773

RomaricMourgues opened this issue Mar 9, 2023 · 6 comments

Comments

@RomaricMourgues
Copy link
Contributor

A lot of issues are related to lack of clarity in our access management modal, here they are:

To be discussed

  • Manage access to a folder -> access for all members of the company is “No access”
  • Expectation: no other members of the company see the folder
  • Reality: user B from the company has full access to the folder
no.access.but.yes.access.mov
  • Manage access to file/folder -> set access for user B to “Read”
  • Expectation: user B cannot download the file or manage access
  • Reality: user be can download the file and manage access
read.only.-.can.dwnld.and.man.access.mov
  • Manage access to a file inside a sub-folder -> inherit parent folder is selected
  • Expectation: the file has same access settings as its parent folder
  • Reality: file has default access settings
inherit.doest.work.mov

This ones are bugs

  • Manage access to a folder -> change access for user B to “No access” and switch to the tab where user B has the Documents tab opened.
  • Expectation: only the folder in question disappears from the space of user B
  • Reality: “Unable to load your files” warning appears and all files and folders disappear for user B. Refreshing the app/page fixes the problem.
changing.access.NB.fixed.after.refresh.app.mov
  • Manage access to public link to folder -> Write -> Copy the link -> follow the link -> Click Upload in the opened tab -> try to upload file
  • Expectation: the file is uploaded to the folder
  • Reality: nothing happens after you try to upload the file, the file isn’t uploaded. Same thing happens when you try to create a version of a file after following a public link
pub.link.write.dnt.w.same.when.try.to.create.version.mov
@RomaricMourgues
Copy link
Contributor Author

RomaricMourgues commented Mar 9, 2023 •
edited
Loading

Fixed

  • 1, 6 and 11 are fixed on next PR

Need design rethink

  • 5 and 9 (related to access management clarity)

@RomaricMourgues
Copy link
Contributor Author

PR status #2774

@RomaricMourgues
Copy link
Contributor Author

@tprudentova for the access management waiting for me to improve the clarity, let me explain how it works:

  • First we look if we are in the context of a public link, if currently checked element correspond to the public link we stop and return expected access level
  • Then we look at direct access info, for instance current user is specifically indicated as "write" access then we use this information and we don't look anywhere else
  • Then we take the maximum level available of this two:
    • Look up recursively and apply previous points to parent folders if 'inherit' is true and get the maximum level returned
    • If we are member of the company, get the defined access level as member of the company

For root and trash, we have special rules depending on if you are guest or not, and admin or not.

This being said, I think we must change the inherit folder and company part, something as simple as "if inherit is on, then company access cannot be restricted", it means the "company has access" will be shown only if inherit is set to off

I'm thinking about clarifying the fact that direct access on user is in priority to the company/inherit access, still thinking about it now.

Finally, you didn't tried it yet but when linking a folder to a chat tab then it works a bit like public sharing for the logic.

@tprudentova
Copy link
Collaborator

@RomaricMourgues okay, I think I got you, thank you!
Maybe (just a suggestion) we could sort the access options in the order of priority? Like, public link on top, them direct access, then inherit, then all members. I'm not sure whether it's a good way to solve this, but it seems more intuitive to consider things at the top of the list more important.
Also, I couldn't find a way to link a folder to a chat... Is this feature not on canary yet or am I just blind? :')

@RomaricMourgues
Copy link
Contributor Author

To link a folder to a chat open a workspace channel then add a new tab at the top and select "Document" then you'll have it.

Screenshot 2023-03-10 at 10 14 53

@tprudentova
Copy link
Collaborator

Ohhhh I see, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RomaricMourgues @tprudentova