Skip to content

perf(xds): do not include tags in CLA #11074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Aug 8, 2024

Checklist prior to review

Draft to test CI first but xref #11065
CLA cache is for service to service communication. We still build endpoint differently for ext services as well as for zone proxies.

MeshLoadbalancingStrategy breaks this. We can try to add this as a hook, so that we remove the tags after all plugins run

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@jakubdyszkiewicz
Copy link
Contributor Author

jakubdyszkiewicz commented Dec 3, 2024

I'm not working on it right now. We need to figure out how to solve MeshLoadbalancingStrategy.

Other ideas are

  • Just build endpoints if we have MLB that uses tags
  • Carry tags in some other way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant