Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple orderblocks #14

Open
einarjohnson opened this issue Mar 16, 2024 · 5 comments
Open

Multiple orderblocks #14

einarjohnson opened this issue Mar 16, 2024 · 5 comments
Assignees
@joshyattridge

Comments

@einarjohnson
Copy link

einarjohnson commented Mar 16, 2024 •
edited
Loading

Hi,
Thanks for a great starting point on building SMC concepts using Python. I am currently trying to use your library/code to find order blocks and I was wondering if you are planning to change the ob function so it returns multiple order blocks?
For instance when I run the code on FLOWUSDT (Bybit perpetual contract) 4H candle data it detects the following order block
image

However, when I use the most popular order-block indicator on TW there are more OB's being displayed
image

image

I'm still getting familiar with your codebase, if I am successful in understanding it properly I can try to contribute a PR.
@joshyattridge joshyattridge self-assigned this Mar 18, 2024
@joshyattridge
Copy link
Owner

Hello @einarjohnson,

I see what you mean although I didn't implement the order block function myself.
Will you be able to assist @rafalsza as you done most of the implementation.
Maybe you can provide a fix?

Thank you

@rafalsza
Copy link
Contributor

it was implemented according to Volumized Order Blocks | Flux Charts not Order block finder

@einarjohnson
Copy link
Author

ah ok, thanks for clarifying @rafalsza

@joshyattridge
Copy link
Owner

@einarjohnson you're welcome to implement an alternative if you wish, then we can give the option of which OB indicator to use.

@einarjohnson
Copy link
Author

sure, I am still investigating on my end what the best way to do this is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshyattridge joshyattridge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshyattridge @einarjohnson @rafalsza