Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PurgeBatchlet and Wildfly 10 #72

Open
Not-Code opened this issue Apr 30, 2016 · 4 comments
Open

PurgeBatchlet and Wildfly 10 #72

Not-Code opened this issue Apr 30, 2016 · 4 comments
Assignees
@chengfang

Comments

@Not-Code
Copy link

The sql and sqlFile batch properties of org.jberet.repository.PurgeBatchlet don't work when jberet is used with Wildfly because the JobRepository is an instance of org.wildfly.extension.batch.jberet.job.repository.JdbcJobRepositoryService and not an instance of org.jberet.repository.JdbcRepository.

So, the condition if (jobRepository instanceof JdbcRepository) that starts the purge of the persistent store is never true.

So far i understand that Wildfly needs to extend the functionality of the JobRepository and since the JdbcRepository is marked as final that is done with a wrapper. I think that this behaviour should be expected and so directly handled inside jberet but I have not still found a good solution.

So, what are your thoughts about this?
Thank you.
@chengfang chengfang self-assigned this May 1, 2016
@chengfang
Copy link
Contributor

@jamezp WDYT?

As a workaround, PurgeBatchlet can always be extended by applications to customize its behavior.

@jamezp
Copy link
Contributor

jamezp commented May 2, 2016

From the WildFly side there's not much we can do. Either the JobRepository needs to change to allow some kind of check. Maybe something like JobRepository.supports(Class<? extends JobRepository> c). I don't love that, but it's an idea.

PurgeBatchlet can't be extended either as it's final. That should probably change.

@chengfang
Copy link
Contributor

Yeah, PurgeBatchlet should change to non-final. Maybe we can try to introspect getDelegate() and if it successfully returns a JdbcRepository, then proceed as usual. I don't like having to change SPI just for this feature, so I'm trying to find what we can do inside PurgeBatchlet.

@jamezp
Copy link
Contributor

jamezp commented May 3, 2016

If we split to annotations into a public API the PurgeBatchlet should probably live there too.

chengfang added a commit that referenced this issue May 6, 2016
@chengfang
Issue #72 fix PurgeBatchlet to work with the JdbcRepository wrapper i…
f02aa54 
…n WildFly, and add wildfly-jberet-samples/purgeJdbcRepository2.
chengfang added a commit that referenced this issue May 6, 2016
@chengfang
Issue #72 add test withSqlFile to wildfly-jberet-samples/purgeJdbcRep…
f699eae 
…ository2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chengfang chengfang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jamezp @chengfang @Not-Code