Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idleExpiry compare UTC and local time #198

Open
koo9 opened this issue Apr 8, 2024 · 0 comments
Open

idleExpiry compare UTC and local time #198

koo9 opened this issue Apr 8, 2024 · 0 comments
Labels

Comments

@koo9
Copy link

koo9 commented Apr 8, 2024

by looking at the code, in https://github.com/moribvndvs/ng2-idle/blob/master/projects/core/src/lib/idleexpiry.ts
in this function isExpired(): boolean { const expiry = this.last(); return expiry != null && expiry <= this.now(); }

this.last() is UTC time, this.now is local time, so it's comparing UTC and local time, is it a bug?

@koo9 koo9 added the bug label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant