FIX: findTransactionError extracted exit_code incorrectly: should che…

…ck compute phase presence
everx-labs · Dec 14, 2022 · 3f348a8 · 3f348a8
1 parent e671d36
commit 3f348a8
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 9 deletions.
diff --git a/contracts/errors.ts b/contracts/errors.ts
@@ -62,10 +62,10 @@ export function findTransactionError(
     const {
         id,
         aborted,
-        compute: { exit_code },
         account_addr,
     } = transaction;
-    const errorCode = exit_code !== 0 ? exit_code : altErrorCode;
+    const exitCode = transaction.compute?.exit_code ?? 0;
+    const errorCode = exitCode !== 0 ? exitCode : altErrorCode;
     if (!aborted && errorCode === 0) {
         return undefined;
     }

diff --git a/dist/contracts/errors.js b/dist/contracts/errors.js
diff --git a/dist/flex/web3/accounts.d.ts b/dist/flex/web3/accounts.d.ts
@@ -19,8 +19,8 @@ export type DerivativeTransaction = {
     out_messages: DerivativeTransactionMessage[];
     account_addr: string;
     aborted: boolean;
-    compute: {
-        exit_code: number;
+    compute?: {
+        exit_code?: number;
     };
     lt: string;
 };

diff --git a/dist/tsconfig.tsbuildinfo b/dist/tsconfig.tsbuildinfo
diff --git a/flex/web3/accounts.ts b/flex/web3/accounts.ts
@@ -34,8 +34,8 @@ export type DerivativeTransaction = {
     out_messages: DerivativeTransactionMessage[];
     account_addr: string;
     aborted: boolean;
-    compute: {
-        exit_code: number;
+    compute?: {
+        exit_code?: number;
     };
     lt: string;
 };