Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash when trying to change edge permissions #15776

Open
Tracked by #15574
namdre opened this issue Nov 25, 2024 · 1 comment
Open
Tracked by #15574

crash when trying to change edge permissions #15776

namdre opened this issue Nov 25, 2024 · 1 comment
Assignees
@palvarezlopez
Labels
a:netedit bug dev_regression Works previously in this version p:important more important than default but not 'critical'
Milestone
1.22.0

Comments

@namdre
Copy link
Contributor

namdre commented Nov 25, 2024 •
edited by palvarezlopez
Loading

Appears after #15725
@namdre namdre added a:netedit bug dev_regression Works previously in this version p:important more important than default but not 'critical' labels Nov 25, 2024
@palvarezlopez palvarezlopez added this to the 1.22.0 milestone Nov 25, 2024
@palvarezlopez palvarezlopez mentioned this issue Nov 25, 2024
Open
56 tasks
@palvarezlopez
Copy link
Member

palvarezlopez commented Nov 25, 2024 •
edited
Loading

The current implementation has a race condition between set attribute and destroy every row (due a historical reasons). GNEFrameAttributeModules::AttributesEditor has to be updated to maintain always a maximum number of rows (for example, 64) instead of destroy it in every inspection.

palvarezlopez added a commit that referenced this issue Nov 26, 2024
@palvarezlopez
Added GNEAttributeRow.cpp. Refs #15776
d5eaf5e
palvarezlopez added a commit that referenced this issue Nov 26, 2024
@palvarezlopez
Added GNEAttributeTable. Refs #15776
e06c506
palvarezlopez added a commit that referenced this issue Nov 26, 2024
@palvarezlopez
Updated GNEAttributeRow. Refs #15776
f868405
palvarezlopez added a commit that referenced this issue Nov 26, 2024
@palvarezlopez
Updated GNEAttributeTable. Refs #15776
c9e8990
palvarezlopez added a commit that referenced this issue Nov 26, 2024
@palvarezlopez
Updated GNEAttributeRow. Refs #15776
9ad6402
palvarezlopez added a commit that referenced this issue Nov 26, 2024
@palvarezlopez
Updated GNEAttributeTable. Refs #15776
de662e5
palvarezlopez added a commit that referenced this issue Nov 26, 2024
@palvarezlopez
Added new getAttributeProperties() in GNETagProperties. Refs #15776
c83012f
palvarezlopez added a commit that referenced this issue Nov 26, 2024
@palvarezlopez
Updated GNEAttributeRow. Refs #15776
f93c1b3
palvarezlopez added a commit that referenced this issue Nov 26, 2024
@palvarezlopez
Updated GNEAttributeTable. Refs #15776
5ed1ab4
palvarezlopez added a commit that referenced this issue Nov 27, 2024
@palvarezlopez
Updated GNEAttributeRow. Refs #15776
e20bf06
palvarezlopez added a commit that referenced this issue Nov 27, 2024
@palvarezlopez
Updated GNEAttributeRow. Refs #15776
f11895a
palvarezlopez added a commit that referenced this issue Nov 27, 2024
@palvarezlopez
Added new attribute property "always enabled". Refs #15776
38000c5
palvarezlopez added a commit that referenced this issue Nov 27, 2024
@palvarezlopez
Updated GNEAttributeRow. Refs #15776
02a1ba9
palvarezlopez added a commit that referenced this issue Nov 27, 2024
@palvarezlopez
Updated GNEAllowVClassesDialog. Refs #15776
709205b
palvarezlopez added a commit that referenced this issue Nov 27, 2024
@palvarezlopez
Updated GNEAttributeRow. Refs #15776
aa996d5
palvarezlopez added a commit that referenced this issue Nov 27, 2024
@palvarezlopez
Updated GNEAttributeRow. Refs #15776
84b3848
palvarezlopez added a commit that referenced this issue Nov 27, 2024
@palvarezlopez
Renamed appEnums. Refs #15776
be000f3
@namdre namdre mentioned this issue Nov 28, 2024
Closed
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Removed all references to old AttributesEditorRows. Refs #15776
a5daff7
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Removed references to inspected elements. Refs #15776
0ed9c10
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Now netedit uses the new GNEAttributeTable. Refs #15776
49c76c2
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Fixed crash in GNEAttributeTable. Refs #15776
0abfbc5
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Updated coloring of GNEAttributeRows. Refs #15776
59188f8
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Renamed defines. Refs #15776
f60ec5c
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Now attributes can be edited as previously. Refs #15776
2c3fe80
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Added new GNEAttributeRow and GNEAttributeTable. Refs #15776
e79329d
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Added new attribute property "Always enabled". Refs #15776
9ddfa94
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Removed references to old GNEFrameAttributeModules::AttributesEditor …
b88604e 
…and GNEFrameAttributeModules::AttributesEditorRow. Refs #15776
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Now netedit uses the new GNEAttributeTable. Refs #15776
c21e37c
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Renamed attributeProperty FLOWDEFINITION to FLOW. Refs #15776
84bb898
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Added EditorOptionsi GNEAttributeTable. Refs #15776
20bc17a
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Renamed GNEAttributeTable to GNEAttributeEditor. Refs #15776
ee66300
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Renamed GNEAttributeEditor to GNEAttributesEditor. Refs #15776
ec466e2
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Renamed GNEAttributeRow to GNEAttributesEditorRow. Refs #15776
9d12099
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Restored flow editor. Refs #15776
deb42ab
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Added GEO Attribute property. Refs #15776
35e3d02
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Removed GEOAttributesEditor and restored by a variant of GNEAttribute…
41f7e0a 
…sEditor. Refs #15776
palvarezlopez added a commit that referenced this issue Nov 28, 2024
@palvarezlopez
Renamed GNEAttributesEditor functions. Refs #15776
043127e
palvarezlopez added a commit that referenced this issue Nov 29, 2024
@palvarezlopez
Added new netedit attributes GNE_ATTR_FLOW_TERMINATE and GNE_ATTR_FLO…
9207a86 
…W_SPACING, used in flow inspector. Refs #15776
palvarezlopez added a commit that referenced this issue Nov 29, 2024
@palvarezlopez
Restored full functionality of Flow editor. Refs #15776
984d199
palvarezlopez added a commit that referenced this issue Nov 29, 2024
@palvarezlopez
Improved editing of GEO Polygons and GEO POIs. Refs #15776
35d7638
palvarezlopez added a commit that referenced this issue Nov 29, 2024
@palvarezlopez
Added custom name to AttributesEditor. Refs #15776
e76845a
palvarezlopez added a commit that referenced this issue Nov 29, 2024
@palvarezlopez
Updated GNEAttributesEditorRow and updated GUIAppEnums. Refs #15776
c43e0dc
palvarezlopez added a commit that referenced this issue Nov 29, 2024
@palvarezlopez
Updated GNEAttributesEditor::EditorOptions. Refs #15776
7566338
palvarezlopez added a commit that referenced this issue Nov 29, 2024
@palvarezlopez
Fixed error editing GEO attribute. Refs #15776
6404d52
palvarezlopez added a commit that referenced this issue Nov 29, 2024
@palvarezlopez
Added new tag property EXTENDED. Refs #15776
f54c515
palvarezlopez added a commit that referenced this issue Nov 29, 2024
@palvarezlopez
Removed GNEFrameAttributeModules::AttributesEditorExtended and integr…
538a9ed 
…ated in GNEAttributesEditor. Refs #15776
palvarezlopez added a commit that referenced this issue Nov 29, 2024
@palvarezlopez
Updated GNEAttributesEditor. Refs #15776
b0bfb6f
palvarezlopez added a commit that referenced this issue Nov 29, 2024
@palvarezlopez
Removed all references to attributesEditorExtendedDialogOpened(). Refs …
1c0ffc0 
…#15776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palvarezlopez palvarezlopez

Labels
a:netedit bug dev_regression Works previously in this version p:important more important than default but not 'critical'
Projects
None yet
Milestone
1.22.0
Development

No branches or pull requests
2 participants
@namdre @palvarezlopez