Refactor PersistentLogin for readability and maintainability #5460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line-o
commented
Sep 30, 2024
.../persistentlogin/src/main/java/org/exist/xquery/modules/persistentlogin/PersistentLogin.java
Show resolved
Hide resolved
line-o
commented
Sep 30, 2024
| @@ -31,6 +31,7 @@ | |||
|
|
|||
| import java.security.SecureRandom; | |||
| import java.util.*; | |||
There was a problem hiding this comment.
Should this be replaced by a list of package imports from java.util?
dizzzz
reviewed
Sep 30, 2024
| @@ -31,6 +31,7 @@ | |||
|
|
|||
| import java.security.SecureRandom; | |||
| import java.util.*; | |||
dizzzz
reviewed
Sep 30, 2024
| /** | ||
| * Functions to access the persistent login module. | ||
| */ | ||
| public class PersistentLoginFunctions extends UserSwitchingBasicFunction { | ||
| private enum Fn { |
There was a problem hiding this comment.
could you give this a better name, as this looks too much on the FN: function namespace
line-o
commented
Sep 30, 2024
| @@ -60,9 +61,9 @@ public static PersistentLogin getInstance() { | |||
|
|
|||
| public final static int DEFAULT_TOKEN_LENGTH = 16; | |||
|
|
|||
| public final static int INVALIDATION_TIMEOUT = 20000; | |||
| public final static int INVALIDATION_TIMEOUT = 1000; | |||
There was a problem hiding this comment.
We need to check if this is safe to lower the timeout to 1 second, was 20 seconds.
| @@ -197,13 +199,15 @@ public DurationValue getTimeToLive() { | |||
|
|
|||
| public boolean checkAndUpdateToken(String token) { | |||
| if (this.token.equals(token)) { | |||
| timeoutCheck(); | |||
There was a problem hiding this comment.
this was moved from update method (line 217)
adamretter
changed the title
adamretter
added
needs 4.x.x backport
needs 5.x.x backport
needs 6.x.x backport
needs develop port
and removed
needs 6.x.x backport
labels
|
Will put this in draft until reviews were addressed. I Might end up re-creating this PR targeting develop and then back port to 6.x.x from there. |
- add Enum for all functions exposed by this module - use Enum in PersistentLoginFunctions.eval - add com.google.code.findbugs to maven dependencies for this extension - invert function authenticated => unauthenticated - make parameters and variables final where possible - add @nullable annotations
line-o
force-pushed
the
refactor/persistent-login
branch
from
f27a5dc
to
ad38cb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
small refactoring of the persistentLogin module
Reference:
Type of tests:
None added