test(ingest/tableau): add test for extract_project_hierarchy scenario #12079
+85
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
hsheth2
reviewed
Dec 10, 2024
metadata-ingestion/tests/integration/tableau/test_tableau_ingest.py
Outdated
Show resolved
Hide resolved
datahub-cyborg
bot
added
pending-submitter-response
datahub-cyborg
bot
added
needs-review
hsheth2
approved these changes
Dec 11, 2024
hsheth2
reviewed
Dec 11, 2024
| # reset the registry to test extract_project_hierarchy=false | ||
| site_source.tableau_project_registry = {} | ||
|
|
||
| config.extract_project_hierarchy = False |
There was a problem hiding this comment.
these ideally should've been two separate unit tests, not smushed into a single test
There was a problem hiding this comment.
I kept it the same to ensure that anyone referencing it can clearly see the distinction between true and false.
There was a problem hiding this comment.
then you should use a parameterized test
hsheth2
changed the title
datahub-cyborg
bot
added
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a scenario where a Tableau site contains four projects: A, B, C, and D, with the following hierarchical relationship:
The goal is to extract assets from project A and its children while explicitly denying the child project B.
If we rely solely on the
project_pattern.allowed()method, project C's assets will not be ingested.This happens because project C is not explicitly included in the
allowlist, nor is it part of thedenylist.However, since
extract_project_hierarchyis enabled, project C should ideally be included in the ingestion process unless explicitly denied.To address this, the function explicitly checks the deny regex to ensure that project C’s assets are ingested if it is not specifically denied in the deny list. This approach ensures that the hierarchy is respected while adhering to the configured allow/deny rules.