Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-plugin) - Allow custom userContext states to be added #12057

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(ui-plugin) - Allow custom userContext states to be added #12057

wants to merge 3 commits into from
+10 −0

Conversation

mkamalas
Copy link
Contributor

@mkamalas mkamalas commented Dec 8, 2024

Background:

In our fork, we have some custom states that we want to store in userContext. So, this PR allows for a custom object to be plugged in to the state and avoids merge conflicts in the userContext main file.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Dec 8, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 8, 2024
@rtekal
Copy link
Contributor

rtekal commented Dec 9, 2024

@jjoyce0510 This PR is general purpose and can help community to store and use the custom context.

jjoyce0510
jjoyce0510 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid to me.

Thanks!

@jjoyce0510
Copy link
Collaborator

Looks lke CI is failing. Try yarn prettier --write src to address.

Cheers
John

@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Dec 9, 2024
@mkamalas
Copy link
Contributor Author

Linting errors have been fixed. Please check.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkamalas @rtekal @jjoyce0510