Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(glossary): support multiple ownership types #12050

Conversation

kevinkarchacryl
Copy link
Contributor

@kevinkarchacryl kevinkarchacryl commented Dec 6, 2024

Edit: PR is linked to acryldata/business-glossary-sync-action#7

This is for supporting multiple ownership types for the glossary, term groups, and individual terms. It also maintains backward compatibility. Previously, you could only have one ownership type like this:
image

But now you can optionally have multiple ownership types like this:
image

In addition, changes need to be made to the glossary sync action repo https://github.com/acryldata/business-glossary-sync-action

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 6, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 6, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 11, 2024
@anshbansal anshbansal added merge-pending-ci A PR that has passed review and should be merged once CI is green. pending-submitter-merge and removed pending-submitter-merge labels Dec 12, 2024
@kevinkarchacryl kevinkarchacryl merged commit 507087a into datahub-project:master Dec 12, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants