feat(ingestion/tableau): verify role assignment to user in test_connection.
#12042
+222
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
hsheth2
requested changes
Dec 5, 2024
metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
Outdated
Show resolved
Hide resolved
datahub-cyborg
bot
added
pending-submitter-response
datahub-cyborg
bot
added
needs-review
hsheth2
requested changes
Dec 6, 2024
metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/tableau/tableau_server_wrapper.py
Outdated
Show resolved
Hide resolved
datahub-cyborg
bot
added
pending-submitter-response
hsheth2
reviewed
Dec 7, 2024
…cryl/datahub-fork into cus3116-failing-cli-0.14.1
datahub-cyborg
bot
added
needs-review
hsheth2
requested changes
Dec 9, 2024
metadata-ingestion/tests/integration/tableau/test_tableau_ingest.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/tableau/tableau_server_wrapper.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
Outdated
Show resolved
Hide resolved
datahub-cyborg
bot
added
pending-submitter-response
…u.py Co-authored-by: Harshal Sheth <[email protected]>
…u.py Co-authored-by: Harshal Sheth <[email protected]>
…u.py Co-authored-by: Harshal Sheth <[email protected]>
datahub-cyborg
bot
added
needs-review
hsheth2
requested changes
Dec 11, 2024
|
|
||
| class UserSiteInfo: | ||
| @staticmethod | ||
| def from_server(server: Server) -> "LoggedInUser": |
There was a problem hiding this comment.
not quite what I wanted
we should have one class: rename LoggedInUser -> UserInfo
that UserInfo class should have the from_server method
| @@ -255,6 +259,45 @@ def get_tableau_auth( | |||
| ) | |||
| return authentication | |||
|
|
|||
| def check_user_role( | |||
There was a problem hiding this comment.
this method should be a standalone function or on the source (as a classmethod), not on the TableauConfig type
| except Exception as e: | ||
| logger.warning(msg=e, exc_info=e) |
There was a problem hiding this comment.
Suggested change
| logger.warning(msg=e, exc_info=e) | |
| logger.warning(f"{e}", exc_info=e) |
datahub-cyborg
bot
added
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.