Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W504 warnings in new pycodestyle #24

Open
felixonmars opened this issue May 11, 2018 · 5 comments
Open

W504 warnings in new pycodestyle #24

felixonmars opened this issue May 11, 2018 · 5 comments
Labels
priority: unplanned Work that we believe should be done, but does not have a higher priority.

Comments

@felixonmars
Copy link
Contributor 

=================================== FAILURES ===================================
_________________________ FLAKE8-check(ignoring E501) __________________________
/build/python-josepy/src/josepy-1.1.0/src/josepy/json_util.py:320:30: W504 line break after binary operator
/build/python-josepy/src/josepy-1.1.0/src/josepy/json_util.py:350:30: W504 line break after binary operator

_________________________ FLAKE8-check(ignoring E501) __________________________
/build/python-josepy/src/josepy-1.1.0/src/josepy/jwk.py:225:21: W504 line break after binary operator

_________________________ FLAKE8-check(ignoring E501) __________________________
/build/python-josepy/src/josepy-1.1.0/src/josepy/jws.py:186:17: W504 line break after binary operator
/build/python-josepy/src/josepy-1.1.0/src/josepy/jws.py:291:13: W504 line break after binary operator
/build/python-josepy/src/josepy-1.1.0/src/josepy/jws.py:292:13: W504 line break after binary operator
/build/python-josepy/src/josepy-1.1.0/src/josepy/jws.py:293:13: W504 line break after binary operator
/build/python-josepy/src/josepy-1.1.0/src/josepy/jws.py:294:13: W504 line break after binary operator

_________________________ FLAKE8-check(ignoring E501) __________________________
/build/python-josepy/src/josepy-1.1.0/src/josepy/util.py:94:17: W504 line break after binary operator

Maybe consider to ignore W504 or update code?
@bmw
Copy link
Member

bmw commented May 21, 2018

Are you still hitting this issue? I'm struggling to reproduce.

@felixonmars
Copy link
Contributor Author

Yes, with a patched flake8 built with latest pycodestyle 2.4. The check W504 was newly added and will be more visible some time later when next stable release of flake8 appears.

@bmw
Copy link
Member

bmw commented May 22, 2018

Is this patched version of flake8 already shipped on Arch Linux?

@felixonmars
Copy link
Contributor Author

It sadly is. Currently I patched josepy's pytest.ini to ignore W504, so it's not in a hurry. More like a reminder for coming changes :)

@bmw
Copy link
Member

bmw commented Jun 4, 2018

Got it. I appreciate the heads up.

We should fix this in the next release of the package.

@bmw bmw added the priority: unplanned Work that we believe should be done, but does not have a higher priority. label Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: unplanned Work that we believe should be done, but does not have a higher priority.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@felixonmars @bmw