Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP feat(icicle): Add icicle MSM support #503

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

WIP feat(icicle): Add icicle MSM support #503

wants to merge 37 commits into from

Conversation

sagar-a16z
Copy link
Contributor

@sagar-a16z sagar-a16z commented Nov 15, 2024 •
edited
Loading

  • Rebased feat(icicle): Add icicle msm support #322
  • Updated to latest icicle release
  • Fixed it to use the GPU correctly
  • Fall back to JOLT's CPU implementations when GPU is unavailable - much faster than the default CPU impl.

This is still WIP because we need to figure out when it's better to use the GPU vs CPU for msms.

@wiz-a16z
Copy link

wiz-a16z bot commented Nov 15, 2024 •
edited
Loading

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities 10 Info
Data Finding Sensitive Data
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations
Total 10 Info

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@sagar-a16z
Copy link
Contributor Author

sagar-a16z commented Nov 15, 2024 •
edited
Loading

With the newest benchmark I added, the GPU perf is actually really good. (This is a WSL machine on a 5800X3D + 3080TI)

CPU

VariableBaseMSM::msm() [mode:JOLT CPU]
                        time:   [807.29 ms 810.86 ms 814.58 ms]

GPU

VariableBaseMSM::msm() [mode:Icicle]
                        time:   [153.71 ms 156.67 ms 159.43 ms]

It’s WAY faster. For some reason it's much slower when running the examples. Maybe because my CPU usage was low while this benchmark ran where as the CPU is pinned when running the examples or maybe because I have plenty of left over memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagar-a16z @PatStiles