Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Messaging Design Changes #606

Open
easyuxd opened this issue Sep 9, 2024 · 2 comments
Open

[Enhancement] Messaging Design Changes #606

easyuxd opened this issue Sep 9, 2024 · 2 comments

Comments

@easyuxd
Copy link
Contributor

easyuxd commented Sep 9, 2024

This is an effort to categorize and clean up all screen types. The changes are itemized below, and are informed by the SeedSigner UX Guidelines I published.

These design enhancements were previously socialized with @kdmukai, @SeedSigner, and @newtonick. The changes are synergistic with upcoming multi-language support, and so I wanted to outline the proposal in full, share my progress, and recruit programming help with the refactoring that is required but beyond my expertise.

I anticipate the refactoring of the menu and dialog screens will impact the current content and therefore may affect the translations.

Overview

  • Reorganized Dialog screens into clearer categories
  • Added new dialog type: Dire Warning
  • Visual clean-up for Dialog screens and Toast component
  • Separated Menu screens into 3 layouts: Grid, List, and Bottom List

Detailed Changes

1. Messaging components (Complete, PR #605)

components

  • New icons: info, sign
  • New color: Dire Warning (#FF5700)

2. Messaging layouts and templatization (NEED HELP)

dialogs

  • Reorganize Dialog screens into clearer categories, add Dire Warning (separate from Warning and Error categories)

  • Refactor dialog layouts (LargeIconStatusScreen)

    • Remove status_headline
    • Change status_color to "GUIConstants.BODY_FONT_COLOR"
  • Templatize dialog categories:

    • Current classes: SuccessScreen, WarningScreen, DireWarningScreen
    • Proposed dialog classes: DefaultScreen, InfoScreen, SuccessScreen, WarningScreen, DireWarningScreen, ErrorScreen
  • Toast categories to align with dialog categories

  • Refactor menu categories: Grid, List, BottomList

    • Grid: no change
    • List: 3 or more items with no descriptive content (add descriptive content area to layout)
    • Bottom List: 3 or less items with descriptive content

3. Messaging content

  • Write more descriptive 2-word screen titles to replace generic titles
  • Add descriptive content to Bottom List menus
  • Requires oversight from @kdmukai, who wrote most of the original content
@alvroble
Copy link
Contributor

This is great, @easyuxd. Thank you for the work of grouping all the issues into one. It was needed so we can all row towards one direction now. I'm able to help with the dialog & toast categorization refactor, as I think those two should go together in the naming.

@bitcoinprecept
Copy link
Contributor

Fantastic work @easyuxd

alvroble added a commit to alvroble/seedsigner that referenced this issue Nov 9, 2024
Fixes / required changes:
* Toast refactor as of SeedSigner#606 guidelines
    - Add toast messaging categories
    - General sizing refactor
* Unbind icon color from text color
* Dynamically adjust toast height
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants