#707: create a kokkos-only pipeline #708
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwschilly
commented
Nov 12, 2024
| @@ -4,7 +4,7 @@ if(PRESSIO_ENABLE_TPL_EIGEN) | |||
| add_serial_utest(${TESTING_LEVEL}_solvers_linear_eigen ${SRC1}) | |||
| endif() | |||
|
|
|||
| if(PRESSIO_ENABLE_TPL_KOKKOS) | |||
| if(PRESSIO_ENABLE_TPL_TRILINOS) | |||
There was a problem hiding this comment.
This change is necessary because the test calls solveAllowMatOverwrite.
This function is in an #if PRESSIO_ENABLE_TPL_TRILINOS block because it uses a teuchos lapack wrapper. So if we're only using Kokkos (and not Trilinos), this function is not found.
cwschilly
force-pushed
the
707-create-a-kokkos-only-pipeline
branch
from
ffb3205
to
a34b642
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #707