Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused DAG Filters #18147

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Remove unused DAG Filters #18147

wants to merge 5 commits into from
+2 −216

Conversation

pinkavaj
Copy link
Contributor

Those filters were added at 2015. The git log ... does not provide much clue what for they were intended, but it seems they were never used.

If anybody have an idea why this might be bad idea, please speek now, otherwise I would like to drop the dead weight to make it easier for next developers.

git log --oneline src/Gui/DAGView/DAGFilter.cpp src/Gui/DAGView/DAGFilter.h
* 5a153e50ff 2023-08-23 wmayer - Gui: modernize C++: use default member init
* c16e88845b 2022-12-02 luz paz - Gui: fix trailing whitespace
* 0c70d45c83 2022-08-09 berniev - Gui: Use override etc 2
* 5587569629 2022-03-06 Uwe - [Gui] DAGView: remove few includes
* f19d424d8b 2016-09-21 wmayer - fix -Wextra in FreeCADGui
* b5519922d8 2016-04-14 Mateusz Skowroński - QString::fromAscii() is obsolete in Qt5. Replace it with fromLatin1().
* 389007f17e 2015-07-14 blobfish - Core: Gui: DAGView: Various changes. See Following.

@github-actions github-actions bot added the Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Nov 26, 2024
@pinkavaj pinkavaj mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pinkavaj