CAM: fixed A, B, and C axis handling; added relevant tests #18103
+290
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
jbaehr
reviewed
Nov 25, 2024
| "G1 X10 Y20 Z30 A-440 B-450 C-460", | ||
| "G1 X0.3937 Y0.7874 Z1.1811 A-440.0000 B-450.0000 C-460.0000", | ||
| "--inches", | ||
| ) |
There was a problem hiding this comment.
These 44 tests are nearly identical. To reduce future maintenance effort I suggest to consolidate them into a single, or perhaps three (normalized, negative and multi-turn angles), tests.
To still keep the coverage up, and to avoid the act-assert-act-assert-act-assert anti-pattern, you could leverage a local function with a sub-test to get parametrizable tests. See here for an example.
There was a problem hiding this comment.
Thanks for the feedback and the example. I agree and will rewrite the tests to make them more maintainable.
There was a problem hiding this comment.
The rewritten tests are now ready for review and/or pulling.
LarryWoestman
force-pushed
the
staging
branch
from
a46823a
to
52f0b8e
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactored* postprocessors treated the rotary axis parameters (A, B, & C) the same as the linear axis parameters (X, Y, & Z). In particular, rotary axis parameter values (which should always be in degrees) are converted "from mm to inches" when the "--inches" argument is passed to the postprocessors. No conversion is necessary or desired.
This PR fixes the code so that the rotary axis parameters are not converted when the "--inches" argument is passed to the refactored* postprocessors.
A few of the existing tests needed to be fixed and more tests were added to check the rotary axis parameters under more circumstances.
This PR will fix issue #18101.