Changeset 12774

Timestamp:

May 11, 2014, 4:41:11 PM (11 years ago)

Author:

Jun Omae

Message:

1.0.2dev: avoid a TypeError from Storage.__del__ on Python interpreter's termination while running setup.py test -s tracopt.versioncontrol.git.tests.git_fs.suite (fixed #11505)

Location:

branches/1.0-stable/tracopt/versioncontrol/git

Files:

• PyGIT.py (modified) (2 diffs)
• tests/PyGIT.py (modified) (2 diffs)
• tests/git_fs.py (modified) (2 diffs)

branches/1.0-stable/tracopt/versioncontrol/git/PyGIT.py

@@ -226 +226 @@
         return self.__inst
 
+    @classmethod
+    def _clean(cls):
+        """For testing purpose only"""
+        with StorageFactory.__dict_lock:
+            cls.__dict.clear()
+            cls.__dict_nonweak.clear()
+
 
 class Storage(object):
@@ -231 +238 @@
 
     __SREV_MIN = 4 # minimum short-rev length
-
 
     class RevCache(tuple):

branches/1.0-stable/tracopt/versioncontrol/git/tests/PyGIT.py

@@ -24 +24 @@
 from trac.util import create_file
 from trac.util.compat import close_fds
-from trac.versioncontrol.api import Changeset, DbRepositoryProvider
+from trac.versioncontrol.api import Changeset, DbRepositoryProvider, \
+                                    RepositoryManager
 from tracopt.versioncontrol.git.git_fs import GitConnector
 from tracopt.versioncontrol.git.PyGIT import GitCore, GitError, Storage, \
@@ -168 +169 @@
 
     def tearDown(self):
+        RepositoryManager(self.env).reload_repositories()
+        StorageFactory._clean()
         self.env.reset_db()
         if os.path.isdir(self.repos_path):

branches/1.0-stable/tracopt/versioncontrol/git/tests/git_fs.py

@@ -29 +29 @@
 from trac.versioncontrol.web_ui.log import LogModule
 from trac.web.href import Href
+from tracopt.versioncontrol.git.PyGIT import StorageFactory
 from tracopt.versioncontrol.git.git_fs import GitConnector
 
@@ -52 +53 @@
 
     def tearDown(self):
+        self._repomgr.reload_repositories()
+        StorageFactory._clean()
         self.env.reset_db()
         if os.path.isdir(self.repos_path):