Skip to content

Commit

Permalink
docs: Fix a couple of typo-ish errors in WritingAnLLVMPass
Browse files Browse the repository at this point in the history
- Make CallGraphSCCPass's paragraph about doFinalization refer to
  runOnSCC instead of runOnFunction, since that's what it's about.
- Fix a reference in the FunctionPass paragraph.

llvm-svn: 222222
  • Loading branch information
bogner committed Nov 18, 2014
1 parent 9211ec4 commit 85b4cd4
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions llvm/docs/WritingAnLLVMPass.rst
Original file line number Diff line number Diff line change
Expand Up @@ -434,9 +434,8 @@ The ``doFinalization(CallGraph &)`` method
virtual bool doFinalization(CallGraph &CG);

The ``doFinalization`` method is an infrequently used method that is called
when the pass framework has finished calling :ref:`runOnFunction
<writing-an-llvm-pass-runOnFunction>` for every function in the program being
compiled.
when the pass framework has finished calling :ref:`runOnSCC
<writing-an-llvm-pass-runOnSCC>` for every SCC in the program being compiled.

.. _writing-an-llvm-pass-FunctionPass:

Expand All @@ -456,7 +455,7 @@ To be explicit, ``FunctionPass`` subclasses are not allowed to:
#. Inspect or modify a ``Function`` other than the one currently being processed.
#. Add or remove ``Function``\ s from the current ``Module``.
#. Add or remove global variables from the current ``Module``.
#. Maintain state across invocations of:ref:`runOnFunction
#. Maintain state across invocations of :ref:`runOnFunction
<writing-an-llvm-pass-runOnFunction>` (including global data).

Implementing a ``FunctionPass`` is usually straightforward (See the :ref:`Hello
Expand Down

0 comments on commit 85b4cd4

Please sign in to comment.