Add support for ASGI pathsend extension
#2435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
requested changes
Jan 22, 2024
Owner
Kludex
left a comment
Kludex
left a comment
There was a problem hiding this comment.
We need tests.
@abersheeran is this the only thing needed on the implementation side?
Contributor
Yes, its actual logic implementation is all on the server side. |
gi0baro
force-pushed
the
asgi-pathsend
branch
from
58c7cde to
30989e0
Compare
Contributor
Author
|
@Kludex I added a test for this, but it only test the correctness of the messages as |
Owner
|
Reference of the previous PR regarding this extension: #1288 |
Contributor
Author
Owner
|
OHHHH, this is the one you created. Sorry! |
Kludex
approved these changes
Jan 22, 2024
Owner
|
Thanks @gi0baro 🙏 |
3 tasks
gi0baro
added a commit
to gi0baro/starlette
that referenced
this pull request
Jul 23, 2024
This reverts commit 7936e86.
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As per title, this adds support for ASGI pathsend extension on
FileResponseclass for servers implementing it.Checklist