Raise WebSocketDisconnect when WebSocket.send() excepts IOError
#2425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Kludex
force-pushed
the
disconnect-websocket-on-send
branch
from
be299f6 to
200c6c1
Compare
Owner
Author
|
It turns out that now it's impossible to create a test with the It's because the |
Owner
Author
|
@encode/maintainers someone? 🙏 |
michaeloliverx
approved these changes
Jan 20, 2024
michaeloliverx
left a comment
michaeloliverx
left a comment
There was a problem hiding this comment.
Don't have a lot of context here but it looks fine at first glance and there is a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should fix the above issue before merging this.
Uvicorn PR: Kludex/uvicorn#2218