refactor(carto): Refactor fetchMap() for deck.gl v9.1 #9232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixpalmer
approved these changes
Nov 5, 2024
| clientId = SOURCE_DEFAULTS.clientId, | ||
| headers = {}, | ||
| clientId, | ||
| headers, |
Collaborator
There was a problem hiding this comment.
Is this a change of behavior?
Collaborator
Author
There was a problem hiding this comment.
Not "intended" to be a change of behavior (the defaults should be populated downstream, once, not in multiple places like they were here) but I do want to do a bit more testing to confirm this before merging. 👍🏻
Collaborator
Author
There was a problem hiding this comment.
Tested on test/apps/carto-map, no changes found compared to 9.0-release. There is one failing map...
b8abc46c-3c7f-489f-b16f-0664872ad82a
... but it also fails on 9.0.
donmccurdy
force-pushed
the
donmccurdy/carto-fetchmap-v9.1
branch
from
18a00ba to
342c815
Compare
Collaborator
Author
|
Updated to |
donmccurdy
force-pushed
the
donmccurdy/carto-fetchmap-v9.1
branch
from
342c815 to
29fc5fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup to #9230, this PR does some internal refactoring of
fetchMap()to reduce the (repeated) use of optional parameters with defaults imported fromSOURCE_DEFAULTS, and tries to decouple the file somewhat from the baseSource() implementation. User-facing API is unchanged.It probably also makes sense to move this function into
@carto/api-clientat some point, but I don't think we're ready to tackle that for v9.1.