Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt existing tests by adding checks for PlantUML 'Syntax Error' messages #280

Open
sjoerdtalsma opened this issue Jun 17, 2020 · 0 comments

Comments

@sjoerdtalsma
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Issue #276 remained undetected for long because although we checked the PlantUML sources that were produced by the Doclet, we didn't test whether these sources still produce accurate diagrams.

Describe the solution you'd like

Fortunately checking for illegal syntax is relatively simple: check for the text "Syntax Error" in the resulting .svg diagram files.
Add this condition to all existing tests. This should then automatically trigger a build failure if a feature becomes unsupported in a future PlantUML version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant