Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

London Elizabeth Line #568

Open
jayfan0 opened this issue Apr 12, 2024 · 3 comments
Open

London Elizabeth Line #568

jayfan0 opened this issue Apr 12, 2024 · 3 comments

Comments

@jayfan0
Copy link

jayfan0 commented Apr 12, 2024

Hello,

London has had a new line opened since 2022 called the Elizabeth Line. Could this be added as a London line please? I see the other lines in the TLEM provider file

Thank you

@schildbach
Copy link
Owner

If that's a subway line it should already be shown in the default subway colors. What you see in the TlemProvider.java is just the custom colors. Feel free to submit a PR for those.

@jayfan0
Copy link
Author

jayfan0 commented Apr 14, 2024

Its a strange hybrid line. Its a subway line under london but overground extending out to the outer parts of east and west london. The line colour is purple. See map here

I'm using an app called Transportr, and the journeys show some train ID numbers(?) rather than "Elizabeth Line". Other subway routes show the line name.

In fact all, if not most journeys in the UK are indicated by the train operator and destination rather than ID numbers which is what this app seems to show for journeys outside of London...

I wouldn't know where to begin tweaking these...

@ghost
Copy link

ghost commented May 20, 2024

i've looked a bit into the JSON response and lizz reports herself as crossrail
data-operator="XR"

so i think that this might work:

        //adding elizabeth line right here and i don't know how to test that. it just looks like it might make some sense.
        //i've looked at a JSON response from traveline and it says following:
            //product	"Elizabeth line"
            //productId	"13"
            //type	"9"
            //code	"18"
            //trainType	"OO"
        if ("1".equals(mot)) {
            if (trainType == "OO" && ("Elizabeth line".equals(product)))
                return new Line(id, network, Product.SUBURBAN_TRAIN, "Elizabeth Line");
        //here goes nothing with Lizz
        STYLES.put("SElizabeth Line", new Style(Style.parseColor("#6950a1"), Style.WHITE));

that's what i'd insert in the TlemProvider.java file

but honestly: i have no clue, it's just a wild guess and i'm by no means a programmer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants