Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ciborium impl of Value::into_ #35

Open
dodomorandi opened this issue Dec 9, 2021 · 2 comments
Open

Use ciborium impl of Value::into_ #35

dodomorandi opened this issue Dec 9, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers low priority

Comments

@dodomorandi
Copy link
Contributor

dodomorandi commented Dec 9, 2021 •
edited
Loading

Once this PR is landed, we can remove our extension trait and directly use Value::into_ methods.

Blocked by enarx/ciborium#34
@dodomorandi dodomorandi added enhancement New feature or request good first issue Good for newcomers low priority labels Dec 9, 2021
@lmammino
Copy link
Member

I just realised that enarx/ciborium#34 was merged, so we can probably get this one done :)

@lmammino
Copy link
Member

Ok, i take that back. It seems those changes are not published yet, so we need to wait for this new issue: enarx/ciborium#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmammino @dodomorandi