Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tk/tckl pkg-config broken on manylinux2014 #1718

Closed
mattip opened this issue Nov 18, 2024 · 4 comments
Closed

tk/tckl pkg-config broken on manylinux2014 #1718

mattip opened this issue Nov 18, 2024 · 4 comments

Comments

@mattip
Copy link
Contributor

mattip commented Nov 18, 2024

PR #1365 added support for tk/tcl 8.6, and removes the static stub libraries. But using pkg-config still has the stub libraries in the link command

# pkg-config tcl --libs
-L/usr/local/lib -ltcl8.6 -ltclstub8.6

 pkg-config tk --libs
-L/usr/local/lib -ltk8.6 -ltkstub8.6 -ltcl8.6 -ltclstub8.6

I am not sure how the cpython build works around this. I ran into this when I tried to use the pkg-config command to build tkinter for PyPy.
@mayeut
Copy link
Member

mayeut commented Nov 18, 2024

These should be private to the cpython builds of manylinux2014. I'll check if/how I can remove all of this from /usr/local.

@mattip
Copy link
Contributor Author

mattip commented Nov 18, 2024

Heh, don't hide it too much, I use it on PyPy :). FWIW, I fixed this by removing the missing stub static libs from the pkgconfig config file. Would you like a PR?

sed -i -e"s/ -ltclstub8.6//" /usr/local/lib/pkgconfig/tcl.pc
sed -i -e"s/ -ltkstub8.6//" /usr/local/lib/pkgconfig/tk.pc

@mayeut
Copy link
Member

mayeut commented Nov 19, 2024

If this is fixed for now on your end, I guess it can wait for the merge of manylinux_2_34 at the end of the week. Almost all scripts are being reworked so I'd rather have this one included in the existing PR.

@mattip
Copy link
Contributor Author

mattip commented Nov 19, 2024

Ahh, cool 097ccb7 fixes this. Closing.

@mattip mattip closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattip @mayeut