Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quick item childen (can be nested) #27

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add quick item childen (can be nested) #27

wants to merge 12 commits into from

Conversation

rafaeldelucena
Copy link
Collaborator

This PR aims to enable to get children from items (also nested items)

@rafaeldelucena rafaeldelucena mentioned this pull request Mar 12, 2018
Open
@parkouss
Copy link
Owner

parkouss commented Jul 9, 2018

This looks nice - could you rebase the code on master please, now that you fixed the travis tests (+1 !) it should compile and every test should pass. Also, if you are motivated, a functional test would be awesome for the new addition. Though I understand if you don't have the time, and I will merge it like this if you want to.

@rafaeldelucena
Copy link
Collaborator Author

Ok, I'll do it!

thony418
thony418 reviewed Jul 13, 2018
View reviewed changes
Copy link
Contributor

@thony418 thony418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed fix should fix Travis build

server/libFunq/player.cpp Show resolved Hide resolved
@rafaeldelucena rafaeldelucena force-pushed the add-quick-item-children branch 6 times, most recently from dbe1d9e to 58b2fc6 Compare September 17, 2018 16:35
@rafaeldelucena
Copy link
Collaborator Author

I'm writing some functional tests for QML and maybe I'll also create the unit tests for this feature.

@parkouss
Copy link
Owner

awesome :)

@rafaeldelucena rafaeldelucena force-pushed the add-quick-item-children branch 3 times, most recently from 626381a to 15f6807 Compare October 24, 2018 05:47
@rafaeldelucena rafaeldelucena force-pushed the add-quick-item-children branch 2 times, most recently from 342b0d5 to ccd8692 Compare February 5, 2019 03:42
@ghost
Copy link

ghost commented Oct 18, 2019

Hi,

are there any updates on this PR?
This would be really relevant for us in regards to our QML application tests.
Is there anything blocking this?

@rafaeldelucena
Copy link
Collaborator Author

Hello @SnkE, the blocker is testing this in Windows, I've created a QML application to make functional tests of this feature. If you have some ideas please let me known.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thony418 thony418 thony418 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafaeldelucena @parkouss @thony418