Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract nose plugin into separate package? #42

Open
ubruhin opened this issue Sep 23, 2018 · 3 comments
Open

Extract nose plugin into separate package? #42

ubruhin opened this issue Sep 23, 2018 · 3 comments
Labels
enhancement

Comments

@ubruhin
Copy link
Contributor

ubruhin commented Sep 23, 2018 •
edited
Loading

Currently funq is strongly coupled with nose, but actually the core functionality (libFunq / server / client) is independent of nose and could also be used with other testing frameworks (or even without any testing framework, but for automating applications with a python script or so). At LibrePCB I use funq with pytest instead of nose because I feel much more comfortable with pytest, but it was a bit a mess to do so because funq is not designed for to be used without nose.

IMHO we could move the nose plugin into a separate package (e.g. funq-nose or nose-funq) and make the funq client completely independent of any testing framework. Or are there other opinions/ideas?
@parkouss
Copy link
Owner

That makes a lot of sense to me, and I too use pytest instead of nose from quite some time now. I like the idea of having some other packages (or maybe using extras, https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-extras-optional-features-with-their-own-dependencies) to ease the use of some test backend. Nose is there, would be fine to have a pytest plugin or something too.

@jacquesknipper
Copy link

Hi guys,
I'm interested in using funq for some QML testing, but I would like to use pytest instead of nose, since I'm reading that you already have something on your side, I'm curious to know how you achieved that and if you started anything migrating the nose dependency into a separate package so pytest could be implemented the same way.

Thanks!

@ubruhin
Copy link
Contributor Author

ubruhin commented Feb 15, 2020

Hi @jacquesknipper,

I didn't start moving the nose dependency into a separate package, I just worked around this issue in my conftest.py: https://github.com/LibrePCB/LibrePCB/blob/master/tests/funq/conftest.py

As far as I remember, it was basically a matter of building the ApplicationContext manually...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rafaeldelucena @ubruhin @parkouss @jacquesknipper