Support authenticating as GitHub Apps instead of using Personal Access Tokens #1311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazhelez
reviewed
Nov 18, 2024
mazhelez
reviewed
Nov 18, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aholstrup1
previously approved these changes
Jan 30, 2025
mazhelez
previously approved these changes
Jan 30, 2025
aholstrup1
previously approved these changes
Jan 30, 2025
mazhelez
approved these changes
Jan 30, 2025
aholstrup1
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first part of supporting GitHub Apps for authentication instead of PATs in GhTokenWorkflow.
After this PR, we still need a PAT for running the End 2 End tests, and we will have to have a PAT for End 2 End tests until we no longer support the versions, which doesn't support using GitHub Apps for authentication. The full scenario end 2 end test does use the GitHub app for authentication and does as such test that GhTokenWorkflow can be a GitHub app.
Also, the microsoft owned repositories used in end 2 end (bcsamples-*) are also using the PAT, as we currently do not have the GitHub App installed in the microsoft org. This will be part of a second part of this - to use the PAT in fewer places in the end 2 end tests.
TODO: