Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker Multi Architecture Images #485

Open
viferga opened this issue Feb 14, 2024 · 3 comments
Open

Docker Multi Architecture Images #485

viferga opened this issue Feb 14, 2024 · 3 comments

Comments

@viferga
Copy link
Member

viferga commented Feb 14, 2024

🚀 Feature

For fully implementing this feature for all architectures, including MacOS M1 etc.. we would need to build docker images for multiple architectures (and maybe multiple OS if possible, although for now, Debian should be enough).

Here's the CI that should be modified:

core/.github/workflows/docker-hub.yml

Line 40 in 380a4a9

# TODO: Build with alpine and provide multiple tags (debian & alpine) once all tests pass

Alpine is not fully supported yet. Debian should be enough for now (bookworm and trixie).

Here's a full tutorial about how to do it with QEMU: https://docs.docker.com/build/ci/github-actions/multi-platform/
@ashu8912
Copy link

Hello @viferga I would like to work on this

@Bcoderx6 Bcoderx6 mentioned this issue Jul 23, 2024
Closed
@viferga
Copy link
Member Author

viferga commented Aug 13, 2024

I made a base version for this, it can be extended further: https://github.com/metacall/core/blob/develop/.github/workflows/docker-hub-platform.yml

@viferga
Copy link
Member Author

viferga commented Nov 7, 2024

We should review the docker-hub-platform.yml, push to the core all the images with different tags and platforms (this includes 4 images for each platform), and then it will be interesting to not just build the image and push to docker but also run the tests in multiplatform environment.

Also adding more architectures would be interesting, here's the complete list:

      "linux/amd64",
      "linux/arm64",
      "linux/riscv64",
      "linux/ppc64le",
      "linux/s390x",
      "linux/386",
      "linux/mips64le",
      "linux/mips64",
      "linux/arm/v7",
      "linux/arm/v6"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viferga @ashu8912