Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore elm-stuff elm files in brunch watched #10

Open
madsflensted opened this issue Dec 26, 2015 · 6 comments
Open

ignore elm-stuff elm files in brunch watched #10

madsflensted opened this issue Dec 26, 2015 · 6 comments

Comments

@madsflensted
Copy link
Owner

Problem: on initial run brunch fires add events for all elm files in the elm-stuff folder when elm files are in subfolder.

@simonh1000
Copy link

If this means when my source code is in e.g. /src then I think I am experiencing it, and it's leading to the watches failing pretty regularly

@lessless
Copy link

@madsflensted is this an brunc or elm-brunch issue?

@madsflensted
Copy link
Owner Author

madsflensted commented Jun 30, 2016

@lessless it is an issue that can easily be handled by adding an elm-stuff pattern toignored in conventions brunch option.
But I thought it would be good if elm-brunch would either ignore files from elm-stuff or at least warn about being called with such files and provide the information on how to set configuration.

@lessless
Copy link

lessless commented Jul 1, 2016

@madsflensted thank you for clarification!

@tommcgurl
Copy link

👍 Thanks @madsflensted for the suggestion. I was facing the same issue and adding the ignored property to my brunch config did the trick. I definitely think adding the warning or even ignoring by default would be super helpful. I'd be happy to take a look and see if I can add that with a PR if this is something everyone would find useful and fitting for this repo.

@tommcgurl
Copy link

After taking a look it seems like this issue is out of the scope of elm-brunch. The purpose of this plugin is simply to run elm make on your specified elm directory in order to compile your elm code. The issue that I'm seeing happens when brunch itself tries to build javascript code within the elm-stuff directory. Is this issue the same for everyone else?

Specifically, I was seeing errors when importing the elm-css package within my elm application. The elm-css package contains some javascript that brunch was not ignoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants