Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WiFi Manager Integration #37

Open
jfujitani opened this issue Jul 8, 2023 · 2 comments
Open

WiFi Manager Integration #37

jfujitani opened this issue Jul 8, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jfujitani
Copy link

Hello,
Are you interested in a PR to integrate WiFi Manager? I have local branch with it integrated so, I can change WiFi networks/passwords without having deploy a new build.

WiFi Manager also supports custom fields, so I've considered adding custom fields to also set. However I haven't gone down that rabbit hole yet.

  • OWM_APIKEY (Not sure if there are any security implications. With it complied it would be harder to get to. If I were to add it to configs, it would likely just be saved in json format using SPIFFS).
  • CITY_STRING (In case I move)
  • LAT (CITY_STRING would be useless without this).
  • LON (CITY_STRING would be useless without this).
  • TIMEZONE (In case I move)
@lmarzen
Copy link
Owner

lmarzen commented Jul 8, 2023

Hi @jfujitani,

This would be an interesting integration. Many people would appreciate this feature. Admittedly, I am not very familiar with this library and only just now skimmed some of the documentation. You are welcome to create a PR and we can work to get it merged into the project. I like the idea of being able to change more commonly used options.

@jfujitani
Copy link
Author

Hi, @lmarzen,

Thanks for the reply. I'll create a PR for the initial WiFi only integration.
There's some things you'll want to look at before going forward with it. I'll have it up in a little bit.

@jfujitani jfujitani mentioned this issue Jul 8, 2023
Closed
@lmarzen lmarzen added the enhancement New feature or request label Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfujitani @lmarzen