Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically commit re-generated build files on PR push events #108

Open
jamesgeorge007 opened this issue Sep 16, 2023 · 4 comments
Open

Automatically commit re-generated build files on PR push events #108

jamesgeorge007 opened this issue Sep 16, 2023 · 4 comments

Comments

@jamesgeorge007
Copy link
Owner

The PR author is expected to re-generate the build by running npm run build and commit the changes. This adds friction and misses out on the cases with PRs opened by Dependabot. There are two approaches that I'm thinking of.

  1. Update the existing workflow to commit the changes after generating the build to branches apart from main.
  2. Author another workflow that gets triggered on push events on PRs that generate the build and commit the changes. The existing workflow will only used for format checks.

We can use a GH Action like git-auto-commit.
@jamesgeorge007
Copy link
Owner Author

@tuunit, appreciate your thoughts and suggestions.

@jamesgeorge007 jamesgeorge007 mentioned this issue Sep 16, 2023
Merged
@tuunit
Copy link
Collaborator

tuunit commented Sep 18, 2023

@jamesgeorge007 the first approach might not work. As far as I know github actions are not allowed to commit changes to a fork of another user. Therefore extending the CI workflow or adding another workflow that gets triggered after a merge from to generate the distribution files and commit them directly to the master branch seems like the proper solution to me.

@jamesgeorge007
Copy link
Owner Author

I prefer generating the dist files straightaway in the PR and avoiding any follow-up commits to the default branch. If the PR author grants write access to the maintainer, won't that suffice for the GH Action 🤔

@tuunit
Copy link
Collaborator

tuunit commented Sep 23, 2023

We can test it I know that in the past GitHub Actions on PRs have been quite restricted because of security reasons. To prevent malicious PRs to make changes to the base repo or get access to repo / org secrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tuunit @jamesgeorge007