Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StatefulFormatter to mesh.ProxyConfig #3350

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add StatefulFormatter to mesh.ProxyConfig #3350

wants to merge 8 commits into from

Conversation

whitneygriffith
Copy link
Contributor

@whitneygriffith whitneygriffith requested a review from a team as a code owner November 6, 2024 07:49
@istio-policy-bot
Copy link

😊 Welcome @whitneygriffith! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 6, 2024
@whitneygriffith whitneygriffith force-pushed the stateful-formatters branch 2 times, most recently from f1c0513 to 7100825 Compare November 6, 2024 07:59
@whitneygriffith whitneygriffith self-assigned this Nov 6, 2024
@whitneygriffith whitneygriffith changed the title Add StatefulFormatter to ProxyConfig Add StatefulFormatter to ProxyConfig and mesh.ProxyConfig Nov 6, 2024
keithmattix
keithmattix requested changes Nov 6, 2024
View reviewed changes
networking/v1beta1/proxy_config.proto Outdated Show resolved Hide resolved
mesh/v1alpha1/proxy.proto Outdated Show resolved Hide resolved
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 19, 2024
keithmattix
keithmattix reviewed Nov 19, 2024
View reviewed changes
mesh/v1alpha1/proxy.proto Outdated Show resolved Hide resolved
releasenotes/notes/preserve-header-case.yaml Outdated Show resolved Hide resolved
@whitneygriffith whitneygriffith changed the title Add StatefulFormatter to ProxyConfig and mesh.ProxyConfig Add StatefulFormatter to mesh.ProxyConfig Nov 19, 2024
keithmattix
keithmattix approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shape LGTM, but the PR may need a rebase to include some reason changes around deeplinks

@whitneygriffith
use google.protobuf.BoolValue
1f47a4f 
Signed-off-by: whitneygriffith <[email protected]>
@howardjohn howardjohn added the do-not-merge/hold Block automatic merging of a PR. label Nov 26, 2024
@howardjohn
Copy link
Member

Put a hold for the docs comment but LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@keithmattix keithmattix keithmattix approved these changes

@howardjohn howardjohn howardjohn approved these changes

Assignees

@whitneygriffith whitneygriffith

Labels
do-not-merge/hold Block automatic merging of a PR. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@whitneygriffith @istio-policy-bot @howardjohn @keithmattix @hzxuzhonghu @istio-testing