Add to gateway documentation to clarify use of non-standard ports. #2732
Conversation
This is generated from the gateway.proto files
istio-testing
added
size/M
|
Hi @jhuttley-F5-com. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
istio-testing
added
ok-to-test
| @@ -35,6 +35,12 @@ import "google/api/field_behavior.proto"; | |||
| // on these ports, it is the responsibility of the user to ensure that | |||
| // external traffic to these ports are allowed into the mesh. | |||
| // | |||
| // Ports 9443 and 2379 must exist on the ingress-gateway, `my-gateway-controller` in the example below. | |||
There was a problem hiding this comment.
which I saw also in the gateway example below.
There was a problem hiding this comment.
Hi, yes there could be more, but at the moment I'm trying to figure out how the process works. it says I need to apply a release-notes-none label and I haven't figure out how to do that!!
There was a problem hiding this comment.
Hi @linsun I cant figure out how to edit this PR to add the release-notes-none label. In addition I set it to "draft" and now see no way to remove that label in the webpage.
https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels#applying-a-label
Does not seem to help as in my own fork, I don't see my PR.
Using gh I dont have access.
? Which repository should be the default? istio/api
✓ Set istio/api as the default repository for the current directory
gh pr list
gh pr edit
? What would you like to edit? Labels
? Labels do-not-merge/work-in-progress, ok-to-test, release-notes-none, size/M
? Submit? Yes
Message: jhuttley-F5-com does not have the correct permissions to execute AddLabelsToLabelable, Locations: [{Line:1 Column:54}]
Do I have to cancel the PR and start again? --John
There was a problem hiding this comment.
Hi, yes there could be more, but at the moment I'm trying to figure out how the process works. it says I need to apply a release-notes-none label and I haven't figure out how to do that!!
I believe only istio members, and maybe its maintainers, can apply the label. A secondary comment is if you look closely, the release-notes_api test is not required in this repo. As such, a failure in that test would not prevent a PR from being merged.
There was a problem hiding this comment.
Thanks for the contribution. Since this change is clarifying documentation and that usually doesn't have a release note, I'll add the release-noes-none label.
istio-testing
added
the
do-not-merge/work-in-progress
ericvn
added
the
release-notes-none
istio-testing
removed
the
do-not-merge/work-in-progress
istio-testing
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This attempt is generated from the gateway.proto files.
did make gen